Skip to content

Upgrade source-map and support limited sourcemap descriptors #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

Upgrade source-map and support limited sourcemap descriptors #863

merged 2 commits into from
Oct 23, 2018

Conversation

@geek
Copy link
Member

@geek geek commented Oct 23, 2018 •
edited
Loading

Marking as a breaking change since the signature for coverage analyze changes to async.

@geek geek added bug Bug or defect breaking changes Change that can breaking existing code dependency Update module dependency labels Oct 23, 2018
@geek geek added this to the 17.0.0 milestone Oct 23, 2018
@geek geek mentioned this pull request Oct 23, 2018
Closed
@geek geek self-assigned this Oct 23, 2018
lloydbenson
lloydbenson approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@lloydbenson lloydbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geek geek merged commit 536c8f3 into hapijs:master Oct 23, 2018
@geek geek deleted the 857 branch October 23, 2018 17:24
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lloydbenson lloydbenson lloydbenson approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@geek geek

Labels

breaking changes Change that can breaking existing code bug Bug or defect dependency Update module dependency

Projects

None yet

Milestone

17.0.0

Development

Successfully merging this pull request may close these issues.

html reporter errors when encountering sourcemap chunks with typescript

3 participants

@geek @lloydbenson @cjihrig