Skip to content

canplayer in setup.py clashes with can-utils #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
royemmerich opened this issue May 10, 2017 · 4 comments
Closed

canplayer in setup.py clashes with can-utils #162

royemmerich opened this issue May 10, 2017 · 4 comments

Comments

@royemmerich
Copy link

royemmerich commented May 10, 2017

The Linux can-utils package already has a canplayer binary which clashes with the canplayer entry point in the latest setup.py.

Trying to compile my yocto image results in the following error:

Collected errors:
 * check_data_file_clashes: Package can-utils wants to install file /home/phyvm/yocto_builds_PD16.2.0/build/tmp/work/phyboard_regor_am335x_1-phytec-linux-gnueabi/phytec-headless-image/1.0-r0/rootfs/usr/bin/canplayer
	But that file is already provided by package  * python-can
 * opkg_install: Cannot install package packagegroup-hwtools.

Removing it from setup.py resolves the problem.

@royemmerich royemmerich changed the title yocto image: canplayer in setup.py clashes with yocto image: canplayer in setup.py clashes with can-utils May 10, 2017
@hardbyte hardbyte changed the title yocto image: canplayer in setup.py clashes with can-utils canplayer in setup.py clashes with can-utils May 10, 2017
@christiansandberg
Copy link
Collaborator

What should it be named instead? Maybe canlogplayer?

@royemmerich
Copy link
Author

what about pycanplayer or python_canplayer?

@hardbyte
Copy link
Owner

What about removing the scripts and just having them as modules?

$ python -m can.player
$ python -m can.logger
$ python -m can.server

@christiansandberg
Copy link
Collaborator

I personally prefer that way since I have control over which interpreter is used. But it is harder to remember.

hardbyte added a commit that referenced this issue May 31, 2017
hardbyte added a commit that referenced this issue Jun 16, 2017
hardbyte added a commit that referenced this issue Jun 16, 2017
hardbyte added a commit that referenced this issue Jun 16, 2017
boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this issue Mar 23, 2018
boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants