Skip to content

Prepare 4.0.0-rc.0 #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Prepare 4.0.0-rc.0 #1241

merged 1 commit into from
Feb 4, 2022

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented Jan 28, 2022

I did not update the Acknowledgements section since it's hard to get an overview over the last few years. Even after assembling the changelog, which already took forever. One needs to also update the CONTRIBUTORS.txt. But both can IMHO also be updated just before the final 4.0.0, and do not need to be ready for the pre-release. The changelog was more important, since people can check the changes and change their code. I'll open an issue for it, but I'm not eager to actually do it ...

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1241 (5b2e343) into develop (24ea2f2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1241      +/-   ##
===========================================
+ Coverage    65.89%   65.93%   +0.04%     
===========================================
  Files           86       86              
  Lines         8887     8887              
===========================================
+ Hits          5856     5860       +4     
+ Misses        3031     3027       -4     

@felixdivo
Copy link
Collaborator Author

@hardbyte I checked the docs for creating a new release and found that I am not able to GPG-sign the wheels (since of course, I don't have your private key). Can you do that instead?

@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 28, 2022
@felixdivo
Copy link
Collaborator Author

Or should I just use this Travis CI job instead? Semms like "no", since that only works when releasing from the master branch (doc).

@hardbyte
Copy link
Owner

I'm traveling(!) until mid next week and don't have gpg keys on me. Happy for you to release binaries without my signature or without any signature though.

@felixdivo
Copy link
Collaborator Author

Okay, then enjoy it 😄 I'll be unavailable 'till then too and will probably release it ~Thursday.

@felixdivo felixdivo merged commit a2c0128 into develop Feb 4, 2022
@felixdivo felixdivo deleted the prepare-release-4.0.0-rc.c branch February 4, 2022 19:10
@felixdivo felixdivo self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants