general cleanup of the can/interfaces/ modules (not yes the ones in c…

…hild folders)

can/interfaces/__init__.py

@@ -1,15 +1,17 @@
-# -*- coding: utf-8 -*-
+#!/usr/bin/env python
+# coding: utf-8
+
 """
 Interfaces contain low level implementations that interact with CAN hardware.
 """
+
 from pkg_resources import iter_entry_points
 
 VALID_INTERFACES = set(['kvaser', 'serial', 'pcan', 'socketcan_native',
                         'socketcan_ctypes', 'socketcan', 'usb2can', 'ixxat',
                         'nican', 'iscan', 'vector', 'virtual', 'neovi',
                         'slcan'])
 
-
 VALID_INTERFACES.update(set([
     interface.name for interface in iter_entry_points('python_can.interface')
 ]))

can/interfaces/iscan.py

@@ -1,17 +1,21 @@
+#!/usr/bin/env python
+# coding: utf-8
+
 """
 Interface for isCAN from Thorsis Technologies GmbH, former ifak system GmbH.
 """
+
 import ctypes
 import time
 import logging
 
 from can import CanError, BusABC, Message
 
-
 logger = logging.getLogger(__name__)
 
 CanData = ctypes.c_ubyte * 8
 
+
 class MessageExStruct(ctypes.Structure):
     _fields_ = [
         ("message_id", ctypes.c_ulong),
@@ -148,11 +152,11 @@ class IscanError(CanError):
 
     def __init__(self, function, error_code, arguments):
         super(IscanError, self).__init__()
-        #: Status code
+        # Status code
         self.error_code = error_code
-        #: Function that failed
+        # Function that failed
         self.function = function
-        #: Arguments passed to function
+        # Arguments passed to function
         self.arguments = arguments
 
     def __str__(self):

can/interfaces/nican.py

@@ -1,10 +1,14 @@
+#!/usr/bin/env python
+# coding: utf-8
+
 """
 NI-CAN interface module.
 
 Implementation references:
 * http://www.ni.com/pdf/manuals/370289c.pdf
 * https://github.com/buendiya/NicanPython
 """
+
 import ctypes
 import logging
 import sys
@@ -13,39 +17,39 @@
 
 logger = logging.getLogger(__name__)
 
-NC_SUCCESS = 0
-NC_ERR_TIMEOUT = 1
-TIMEOUT_ERROR_CODE = -1074388991
+NC_SUCCESS =            0
+NC_ERR_TIMEOUT =        1
+TIMEOUT_ERROR_CODE =    -1074388991
 
-NC_DURATION_INFINITE = 0xFFFFFFFF
+NC_DURATION_INFINITE =  0xFFFFFFFF
 
-NC_OP_START = 0x80000001
-NC_OP_STOP = 0x80000002
-NC_OP_RESET = 0x80000003
+NC_OP_START =           0x80000001
+NC_OP_STOP  =           0x80000002
+NC_OP_RESET =           0x80000003
 
-NC_FRMTYPE_REMOTE = 1
-NC_FRMTYPE_COMM_ERR = 2
+NC_FRMTYPE_REMOTE =     1
+NC_FRMTYPE_COMM_ERR =   2
 
-NC_ST_READ_AVAIL = 0x00000001
-NC_ST_WRITE_SUCCESS = 0x00000002
-NC_ST_ERROR = 0x00000010
-NC_ST_WARNING = 0x00000020
+NC_ST_READ_AVAIL =      0x00000001
+NC_ST_WRITE_SUCCESS =   0x00000002
+NC_ST_ERROR =           0x00000010
+NC_ST_WARNING =         0x00000020
 
-NC_ATTR_BAUD_RATE = 0x80000007
+NC_ATTR_BAUD_RATE =     0x80000007
 NC_ATTR_START_ON_OPEN = 0x80000006
-NC_ATTR_READ_Q_LEN = 0x80000013
-NC_ATTR_WRITE_Q_LEN = 0x80000014
-NC_ATTR_CAN_COMP_STD = 0x80010001
-NC_ATTR_CAN_MASK_STD = 0x80010002
-NC_ATTR_CAN_COMP_XTD = 0x80010003
-NC_ATTR_CAN_MASK_XTD = 0x80010004
+NC_ATTR_READ_Q_LEN =    0x80000013
+NC_ATTR_WRITE_Q_LEN =   0x80000014
+NC_ATTR_CAN_COMP_STD =  0x80010001
+NC_ATTR_CAN_MASK_STD =  0x80010002
+NC_ATTR_CAN_COMP_XTD =  0x80010003
+NC_ATTR_CAN_MASK_XTD =  0x80010004
 NC_ATTR_LOG_COMM_ERRS = 0x8001000A
 
-NC_FL_CAN_ARBID_XTD = 0x20000000
-
+NC_FL_CAN_ARBID_XTD =   0x20000000
 
 CanData = ctypes.c_ubyte * 8
 
+
 class RxMessageStruct(ctypes.Structure):
     _pack_ = 1
     _fields_ = [

can/interfaces/slcan.py

@@ -1,7 +1,10 @@
+#!/usr/bin/env python
+# coding: utf-8
+
 """
 Interface for slcan compatible interfaces (win32/linux).
 
-Note Linux users can use slcand/socketcan as well.
+Note: Linux users can use slcand/socketcan as well.
 """
 
 from __future__ import absolute_import
@@ -85,6 +88,7 @@ def __init__(self, channel, ttyBaudrate=115200, timeout=1, bitrate=None, **kwarg
                 raise ValueError("Invalid bitrate, choose one of " + (', '.join(self._BITRATES)) + '.')
 
         self.open()
+
         super(slcanBus, self).__init__(channel, **kwargs)
 
     def recv(self, timeout=None):

can/interfaces/virtual.py

@@ -1,11 +1,12 @@
-# -*- coding: utf-8 -*-
+#!/usr/bin/env python
+# coding: utf-8
 
 """
 This module implements an OS and hardware independent
 virtual CAN interface for testing purposes.
 
 Any VirtualBus instances connecting to the same channel
-will get the same messages.
+and reside in the same process will receive the same messages.
 """
 
 import logging
@@ -14,11 +15,10 @@
     import queue
 except ImportError:
     import Queue as queue
-from can.bus import BusABC
 
+from can.bus import BusABC
 
 logger = logging.getLogger(__name__)
-#logger.setLevel(logging.DEBUG)
 
 
 # Channels are lists of queues, one for each connection