Skip to content

Add typing annotations for slcan interface #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

karlding
Copy link
Collaborator

@karlding karlding commented May 9, 2020

This works towards PEP 561 compatibility.

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #832 into develop will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff            @@
##           develop     #832   +/-   ##
========================================
  Coverage    70.43%   70.44%           
========================================
  Files           70       70           
  Lines         6830     6835    +5     
========================================
+ Hits          4811     4815    +4     
- Misses        2019     2020    +1     

@karlding karlding force-pushed the add_typing_for_slcan_interface branch from b5a58b1 to 3c2c04e Compare May 16, 2020 19:31
This works towards PEP 561 compatibility.
@karlding karlding force-pushed the add_typing_for_slcan_interface branch from 3c2c04e to e045043 Compare May 28, 2020 07:05
Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely typed

@mergify mergify bot merged commit c77739b into hardbyte:develop Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants