Fix truncated config prompts (fixes #94) #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hartwork
requested changes
May 22, 2024
There was a problem hiding this comment.
@jmoses could you make CI at https://github.com/hartwork/git-delete-merged-branches/actions/runs/9194449396/job/25288409696?pr=176#step:4:138 happy by adjusting the formatting slightly, as a second commit or amendment to the first one? Thank in advance!
|
Yeah, no problem. I didn't even notice the pre-commit config in the repo. |
This change removes the `max` dimension from the prompt-toolkit windows used during configuration. While the windows enabled the text to wrap, the max was set to the number of lines, so when the text had to wrap the previous lines ended up "scrolled" off the top of the window.
hartwork
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
maxdimension from the prompt-toolkit windows used during configuration. While the windows enabled the text to wrap, the max was set to the number of lines, so when the text had to wrap the previous lines ended up "scrolled" off the top of the window.This should fix issue #94