Skip to content

Add instances for Solo (GHC-9.0 and 9.2) #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phadej opened this issue Aug 30, 2021 · 4 comments
Closed

Add instances for Solo (GHC-9.0 and 9.2) #67

phadej opened this issue Aug 30, 2021 · 4 comments

Comments

@phadej
Copy link
Contributor

phadej commented Aug 30, 2021

cc @treeowl

@treeowl
Copy link
Contributor

treeowl commented Aug 30, 2021

Yes. I still don't have solid word on whether it'll be in base in 9.2, but it's already in ghc-prim.

@phadej
Copy link
Contributor Author

phadej commented Aug 30, 2021

It would be great if deepseq bundled with GHC-9.2 had instances already (depending on ghc-prim shouldn't be a problem).

Ping @sjakobi

@sjakobi
Copy link
Member

sjakobi commented Sep 1, 2021

@phadej I assume you pinged me believing that I'm a a maintainer for deepseq. I'm not though. All my commits to deepseq were merged by @chessai, who is the only active deepseq maintainer I'm aware of.

@chessai
Copy link
Member

chessai commented Sep 1, 2021

I would take a PR for this. @treeowl we can just depend on ghc-prim without issue, if Solo won't be in base in 9.2. cc @bgamari for whether or not that's the case

phadej added a commit to phadej/deepseq that referenced this issue Sep 1, 2021
phadej added a commit to phadej/deepseq that referenced this issue Sep 1, 2021
@chessai chessai closed this as completed in 3b89f98 Sep 1, 2021
mixphix pushed a commit that referenced this issue Nov 9, 2021
rebased onto v1.4.6.0
mixphix pushed a commit that referenced this issue Nov 14, 2021
rebased onto unfck-version-history to remove 'infixr 0 `deepseq`'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants