Fix: Filter out private internal libraries from package pages #1437
Conversation
Co-authored-by: nikita-volkov <[email protected]>
Co-authored-by: nikita-volkov <[email protected]>
…-visibility Fix: Filter out private internal libraries from package pages
| in (libName lib, ModSigIndex { modIndex = mod_ix, sigIndex = sig_ix }) | ||
| where | ||
| -- Only show main library or internal libraries with public visibility | ||
| isPublicLibrary lib = libName lib == LMainLibName |
There was a problem hiding this comment.
Is it insufficient to check only libVisibility?
There was a problem hiding this comment.
I don't know but this solution seems safe even if it is sufficient.
There was a problem hiding this comment.
Cabal does not allow visibility: private for the main library, so I think checking just libVisibility is enough (and more idiomatic).
|
|
||
| allCondLibs :: GenericPackageDescription -> [(LibraryName, CondTree ConfVar [Dependency] Library)] | ||
| allCondLibs desc = maybeToList ((LMainLibName,) <$> condLibrary desc) | ||
| allCondLibs desc = filter (isPublicCondLib . snd) $ |
There was a problem hiding this comment.
Isn't this the function responsible for contents on pages like https://hackage.haskell.org/package/tar-0.7.0.0/dependencies? If yes then I think it should continue showing all sublibraries, even internal ones.
There was a problem hiding this comment.
The only place where allCondLibs is used is
There was a problem hiding this comment.
Exactly, which suggests to me that this function is to list package dependencies. I don't think we want to hide package dependencies of internal libraries, it would be quite misleading for readers. (I'm not a maintainer here)
There was a problem hiding this comment.
Okay. I've removed those changes.
visibility can be a part of CondTree, e. g.,
```haskell
library foo-internal
if flag(foo)
visibility: public
else
visibility: private
```
See haskell#1437 (comment)
|
Have you tested this with puresat? Or do you want me to test it? |
4 participants
Addresses the bug described in #1346.
Should be noted that the patch is generated with AI.