This repository was archived by the owner on Oct 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 206
Improve quality and information density of error message #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73bb5c1
to
e96aa78
Compare
e96aa78
to
b71df18
Compare
fendor
commented
Dec 30, 2019
42c9742
to
2bab815
Compare
Example error message:
|
2bab815
to
7493d69
Compare
jneira
suggested changes
Jan 2, 2020
lukel97
reviewed
Jan 2, 2020
It injects a message that gets processed in the right context.
Co-Authored-By: Luke Lau <[email protected]>
e9239b9
to
5e4a8c6
Compare
jneira
approved these changes
Jan 4, 2020
alanz
approved these changes
Jan 4, 2020
7f3f6a9
to
222797e
Compare
lukel97
approved these changes
Jan 5, 2020
This LGTM! Looking forward to having this in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509
Improves amount of information the error message gives.
Also aims to give: possible solutions, and teaching material.