This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Improvements of install script and macos-installhs-cabal new azure job #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused imports
* Pass number of jobs and verbosity shake args to build tools
* Use custom cabal.project-${ghcVersion} if exists
* Add comments with the possible resolvers to shake.yaml
jneira
changed the title
|
Finally i removed the sharing between the jobs arg of shake and the build tool: the output of shake with more than one job was interleaved and, in general, we will want different values of jobs for shake and stack/cabal frequently. |
fendor
reviewed
Feb 26, 2020
|
My mistake was mix azure and install changes so the pr is bigger than necessary |
|
Well all ci is green (including install.hs jobs) and some changes are needed to make easier ghc-8.8.3 support, so i am gonna merge it |
jneira
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Mar 8, 2020
Port hie changes in install script of pull haskell/haskell-ide-engine#1665
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal.project-ghc-8.8.2that will be used by the scriptI am not sure about the "pass number of jobs and verbosity shake args to build tools". It is a cheap way to let users control the number of jobs and verbosity but they are shared between the run of the script itself and the calls to build tools.
Fixes some warts described in #1664