Skip to content

New rename plugin implementation #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 21, 2021
Merged

New rename plugin implementation #2108

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
eb93be9
initial commit
OliverMadine Aug 17, 2021
3fd6b8a
code style
OliverMadine Aug 17, 2021
eb329be
enable for ghc < 8.8.0
OliverMadine Aug 17, 2021
63e3735
Merge branch 'haskell:master' into rename-plugin-directly-parse-source
OliverMadine Aug 17, 2021
78474c6
remove aeson from build-depends
OliverMadine Aug 17, 2021
09dfa3b
update support
OliverMadine Aug 17, 2021
108d637
enable plugin for testing
OliverMadine Aug 17, 2021
9cc18ee
fix test.yml
OliverMadine Aug 17, 2021
e5ad66d
Merge branch 'master' into rename-plugin-directly-parse-source
OliverMadine Aug 17, 2021
bcbde30
code style, ghc9 retrie bump
OliverMadine Aug 17, 2021
d279cab
Merge branch 'rename-plugin-directly-parse-source' of github.com:Oliv…
OliverMadine Aug 17, 2021
6c994a0
avoid using Data.List.nub
OliverMadine Aug 17, 2021
2879596
code style
OliverMadine Aug 18, 2021
e3ddd94
code style / performance
OliverMadine Aug 19, 2021
d7639ea
Merge branch 'master' of github.com:OliverMadine/haskell-language-ser…
OliverMadine Aug 19, 2021
aa599e2
replace GhcPlugins import with Name import
OliverMadine Aug 19, 2021
89d287c
use GHC.Types.Name for ghc >= 9.0.1
OliverMadine Aug 19, 2021
40d973e
rebase master
OliverMadine Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid using Data.List.nub
  • Loading branch information
@OliverMadine
OliverMadine committed Aug 17, 2021
commit 6c994a0fb22858124a4a2ce15237e24378c5f769
4 changes: 2 additions & 2 deletions plugins/hls-rename-plugin/src/Ide/Plugin/Rename.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import qualified Data.Bifunctor
import Data.Containers.ListUtils
import Data.Generics
import qualified Data.HashMap.Strict as HM
import Data.List
import qualified Data.HashSet as HashSet
import qualified Data.Map as M
import Data.Maybe
import qualified Data.Text as T
Expand Down Expand Up @@ -43,7 +43,7 @@ renameProvider state pluginId (RenameParams (TextDocumentIdentifier uri) pos _pr
oldName <- (handleMaybe "error: could not find name at pos" . listToMaybe) =<<
getNamesAtPos state pos nfp
refs <- refsAtName state nfp oldName
refFiles <- mapM safeGetNfp (nub [uri | Location uri _ <- refs])
refFiles <- mapM safeGetNfp (HashSet.toList $ HashSet.fromList [uri | Location uri _ <- refs])

let newOccName = mkTcOcc $ T.unpack newNameText
nfpEdits <- mapMToSnd (getSrcEdits state (renameRefs refs newOccName)) refFiles
Expand Down