Skip to content

Improve logging #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Feb 20, 2022
Merged

Improve logging #2558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
671211e
convert to contravariant logging style part 1, uses additional hardco…
eddiemundo Jan 6, 2022
acc1ef4
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo Jan 6, 2022
bb2c6a2
convert Session to contravariant logging style
eddiemundo Jan 6, 2022
235b87d
convert Plugin/HLS and FireStore to contravariant logging style
eddiemundo Jan 6, 2022
b4ebdd7
convert Rules (and most of the universe) to contravariant logging style
eddiemundo Jan 6, 2022
c0190d7
fix tests, allow old style logging and contravariant logging to write…
eddiemundo Jan 7, 2022
9946830
fix import inside wrong CPP
eddiemundo Jan 8, 2022
20a3761
add CPP for LogTactic constructor
eddiemundo Jan 8, 2022
528439c
remove redundant import
eddiemundo Jan 8, 2022
e69839d
fix ghcide tests
eddiemundo Jan 8, 2022
e6b4bd7
remove unused import
eddiemundo Jan 8, 2022
fb5033a
fix plugin tests
eddiemundo Jan 8, 2022
4cfa737
LSP_TEST_STDERR should apply to contra logger as well
eddiemundo Jan 8, 2022
c874657
fix tactic plugin test
eddiemundo Jan 8, 2022
2b3b3b3
use CPP for Log datatype plugin constructors, remove unused imports
eddiemundo Jan 9, 2022
23a57c2
add a few Pretty instances, add prettyprinter to haskell-language-sev…
eddiemundo Jan 9, 2022
504a3df
add Pretty Log instances for Session, FileStore, Notifications
eddiemundo Jan 10, 2022
17937d2
add remaining Pretty Log instances
eddiemundo Jan 10, 2022
a2fe371
add logToPriorities
eddiemundo Jan 11, 2022
5d879b0
fix slight interleaving issue with hslogger and logger both logging, …
eddiemundo Jan 11, 2022
9178f1c
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo Jan 11, 2022
e94fd03
forgot to add .cabal files with hslogger dep
eddiemundo Jan 11, 2022
eb7a69a
dont use UnliftIO file IO helpers because they are too new
eddiemundo Jan 11, 2022
d430883
remove log helper comments, use Doc instead of Text as final console/…
eddiemundo Jan 11, 2022
14a126c
remove accidentally added useless file, removed prettyprinter dep fro…
eddiemundo Jan 11, 2022
37ddc54
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo Jan 11, 2022
e7f8320
use deprecated prettyprint modules import for the sake of circleci gh…
eddiemundo Jan 12, 2022
0ced860
fix conflicts
eddiemundo Feb 1, 2022
23c2ad9
use dummy stderr logger for plugin cli commands, use priorityToHsLogg…
eddiemundo Feb 1, 2022
72b441e
remove old plugin detritus that somehow got committed
eddiemundo Feb 1, 2022
198e0ba
fix prettyprinter imports for 8.6.5
eddiemundo Feb 1, 2022
74e9c0e
try enforcing prettyprinter bounds?
eddiemundo Feb 1, 2022
5f045ed
enforcing bound makes no sense
eddiemundo Feb 1, 2022
a6d0ad1
fix merge conflict
eddiemundo Feb 1, 2022
2a9f686
maybe changing stack yamls does trick
eddiemundo Feb 1, 2022
42c22e5
filter out warnings when their diags are empty to more closely match …
eddiemundo Feb 1, 2022
d13eb23
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo Feb 3, 2022
1978a52
add ability to select wanted logging columns, match prev ghcide exe l…
eddiemundo Feb 3, 2022
24aa5f6
dont log anything when diags are empty in some defineEarlyCutoff vers…
eddiemundo Feb 3, 2022
483b565
use non-deprecated prettyprinter imports
eddiemundo Feb 3, 2022
c2d3d01
fix ghcide test module
eddiemundo Feb 3, 2022
8355111
change logWith to accept priority at call site, remove all logToPrior…
eddiemundo Feb 4, 2022
35e0652
fix conflicts
eddiemundo Feb 4, 2022
6666995
remove useless hiding import list, add comments to default recorder m…
eddiemundo Feb 5, 2022
52c5a55
make cradleToOptsAndLibDir take concrete cradle to remove existential…
eddiemundo Feb 5, 2022
cc7dd2b
Types.Logger now re-exports prettyprinter, remove unused dependencies…
eddiemundo Feb 5, 2022
88ae7e2
existential type var to remove boilerplate in Plugins.hs, remove a fe…
eddiemundo Feb 6, 2022
1fd42ae
add SourceLoc logging column, inline logToDoc functions, add comment …
eddiemundo Feb 6, 2022
5bb4fcf
fix conflicts
eddiemundo Feb 20, 2022
c1f1f3d
qualify a name to match original source
eddiemundo Feb 20, 2022
3d71348
fix -WError
eddiemundo Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
convert Session to contravariant logging style
  • Loading branch information
@eddiemundo
eddiemundo committed Jan 6, 2022
commit bb2c6a23d4cb17463ca4c842575893b69fa37901
Loading