Disallow leading spaces in error regexp in interactive mode.

[ikirill]

Disallow leading spaces in error regexp in interactive mode.

[gracjan]

Fixes #635.

Note that we should really have a test suite with examples of texts that should and should not be matched.

[ikirill]

The old regexp was really bad, but the new one of yours isn't that much better either.

haskell-compilation-error-regexp-alist and haskell-process-parse-error seem to do the actual work of parsing the error message. I just meant to fix the thing that I thought was immediately wrong with it.

What about this? It matches the filename greedily. Also, I don't think filenames are really restriced to alnum characters, even though module names might be.

(rx line-start
    (group
     (+ (not (any control))))
    ?:
    (group
     (+ (any digit))
     ?:
     (+ (any digit))
     (? ?-
        (+ (any digit))))
    ?:
    )
"^\\([^[:cntrl:]]+\\):\\([[:digit:]]+:[[:digit:]]+\\(?:-[[:digit:]]+\\)?\\):"

[gracjan]

Does GHC do some quoting/escaping should a file name contain unfriendly character like on of `:'"/?

[gracjan]

Can you please create some ert tests for this function? I feel uneasy accepting this commit without any tests whatsoever.

Please create a new file tests/interactive-haskell-mode-tests.el, copy paste a test from one of the other files in tests and add some lines that you want matches and some other that you want to not match.

[ikirill]

Does GHC do some quoting/escaping should a file name contain unfriendly character like on of `:'"/?

Filenames (base names and dir names) are very unlikely to contain special characters like :/, especially when those can be directory separators. On the other hand, quotes are not a problem:

test"`'.hs:2:8-9: Couldn't match expected type ‘IO ()’ with actual type ‘()’ …

When the colon comes from a C:\... path on windows, it should be handled by the greediness of the + in the regexp.

[gracjan]

@ikirill: Can we have some ert tests for this? It is a very useful functionality, but we must have tests before we merge.

[gracjan]

@ikirill: What's up with this one? Have we achieved consensus here?

Do we have tests?

[gracjan]

@ikirill ?

[gracjan]

@bergey: Daniel, if you had time to take this one over it would be beyond great. We need tests.

[bergey]

OK, I'll add tests for this.