Error overlays #770
Error overlays #770
Conversation
|
Origin PR: #766 |
| (error (list 'haskell-error-face haskell-check-error-fringe))) | ||
| (overlay-put ovl 'before-string fringe) | ||
| (overlay-put ovl 'face face)))))) | ||
|
|
||
| (defun haskell-process-errors-warnings (module-buffer session process buffer &optional return-only) | ||
| "Trigger handling type errors or warnings. Either prints the |
There was a problem hiding this comment.
Can you please add second whitespace after . (emacs lint produces a warnings about this)?
|
very nice! |
|
@geraldus, pushed, but, if I'm not wrong the lack of a double-space in that docstring wasn't introduced by me. |
|
@deepfire: Good stuff. There are some things to get in shape, overall this is pretty cool thing! |
deepfire
force-pushed
the
error-overlays
branch
5 times, most recently
from
6106eba to
ae81a0c
Compare
|
@gracjan, I'm thinking.. is it time to separate overlay functions into |
deepfire
force-pushed
the
error-overlays
branch
2 times, most recently
from
945f9b0 to
81c1af4
Compare
|
@gracjan, after a litany of curses I have made And I can happily report that:
I'm not sure if this constitutes sufficient testing, though. |
|
Thanks.
|
Error overlays in haskell-interactive-mode
|
Cool, thanks! Let's try this out! |
|
@geraldus, it's somewhat incomplete without the other pull requests, I'm afraid.. |
|
@geraldus, at a minimum you would want: |
| @@ -49,6 +49,8 @@ | |||
| (define-key map (kbd "C-c C-x") 'haskell-process-cabal) | |||
| (define-key map [?\C-c ?\C-b] 'haskell-interactive-switch) | |||
| (define-key map [?\C-c ?\C-z] 'haskell-interactive-switch) | |||
| (define-key map (kbd "M-n") 'haskell-goto-next-error) | |||
| (define-key map (kbd "M-p") 'haskell-goto-prev-error) | |||
There was a problem hiding this comment.
Aren't these going to conflict with ghc-mod?
There was a problem hiding this comment.
@DanielG, do you mean with:
(defvar ghc-previous-key "\ep")
(defvar ghc-next-key "\en")
I must say I overlooked this, then..
But then, there's the more pressing question of having two sets of overlays on at the same time, which is still unresolved.
No description provided.