Skip to content

Better tests for ‘haskell-indentation-mode’ #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

mrkkrp
Copy link
Contributor

@mrkkrp mrkkrp commented Aug 15, 2015

Here is better helper for testing, a macro to eliminate boilerplate and more dense tests. Three last tests are strange (commented). Also, I don't know if contents of current line should affect found indentations or collection of indentation columns is completely defined by context set in previous lines.

Criticism is welcome. I haven't silenced failing tests for now.

Note that it's always clear which "sub-case" failed because I compare positions too, so they are shown when something fails, this also helps ensuring that point can be placed in specified position.

@mrkkrp
Copy link
Contributor Author

mrkkrp commented Aug 17, 2015

@gracjan, Here, I fixed those issues. In general, feel free to change tables of indentations, because you may want to give user more alternatives or something, just make sure it makes sense and it's consistent.

As you can see tests marked with asterisk * are allowed to fail.

gracjan added a commit that referenced this pull request Aug 17, 2015
Better tests for ‘haskell-indentation-mode’
@gracjan gracjan merged commit 42d5d76 into haskell:master Aug 17, 2015
@gracjan
Copy link
Contributor

gracjan commented Aug 17, 2015

Thanks. This is good as it is. Now we need more meaningful tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants