Fix out-of-order session startup. #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the responses to the startup commands could be delayed, arriving so late that they appeared to be in response to later commands (e.g. a :load). By setting the prompt last, only one prompt marker will be sent for the whole startup procedure.
gracjan
added a commit
that referenced
this pull request
Sep 18, 2015
Fix out-of-order session startup.
|
I've merged this because it is better than the version before. The correct way to do this is to use ghci multi line capabilities. Can you look into this? |
|
Thanks for merging this. I'm happy to look more into this, but I'm not sure what you mean. If I understand it right, ghci's multiline input is for splitting one big command over several lines, but what we want is to send several independent commands in one line. I don't think ghci supports that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the responses to the startup commands could be delayed,
arriving so late that they appeared to be in response to later
commands (e.g. a :load). By setting the prompt last, only one prompt
marker will be sent for the whole startup procedure.
Should fix issue #882.