-
Notifications
You must be signed in to change notification settings - Fork 10
New Departures and Deviations based on new SL Traffic API #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @NecroKote! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Thanks for undertaking this @NecroKote |
This PR adresses #68 #67
This PR contains:
IMPORTANT: new sensors are NOT compatible with the existing Departure Card.
This was a necessary sacrifice. But I'm also working on overhauling the Departure Card as well (typescript + Lit would give better maintainability) and should present it soon.
This PR targets the
dev
branch, as a couple of things still need to be improved before releasing it.Overall, consider this a major WIP refactoring.
What's missing: