Skip to content

add support for neovim #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Cyperwu
Copy link
Contributor

@Cyperwu Cyperwu commented Jun 11, 2020

Notice that on vim 8.0+, job_status returns "run", "fail" or "dead". So I consider the job_status check branch is a bug.
Tested on nvim v0.5.0-6ca7ebb

Notice that on vim 8.0+, `job_status` returns` "run", "fail" or "dead". So I consider the `job_status` check branch is a bug.
Tested on `nvim v0.5.0-6ca7ebb`
@heavenshell
Copy link
Owner

@Cyperwu Thx for sending PR.
I'm currenlty bit busy now.
Maybe I can look into this weekend.

@heavenshell
Copy link
Owner

@Cyperwu
Can you add followings to .travis.yml?

  - env: ENV="Neovim"
    install:
      - mkdir -p ~/tmp/nvim/bin
      - curl -L https://github.com/neovim/neovim/releases/download/v0.4.3/nvim.appimage -o ~/tmp/nvim/bin/nvim
      - chmod u+x ~/tmp/nvim/bin/nvim

    script:
      - VIM_EXE=$HOME/tmp/nvim/bin/nvim ./run.sh

and than CI would be passed, I'll merge your PR.

@Cyperwu
Copy link
Contributor Author

Cyperwu commented Jun 15, 2020

Sorry for late reply. I'll do it.

@heavenshell
Copy link
Owner

@Cyperwu Thank you for adding CI.
CI was failing.
https://travis-ci.org/github/heavenshell/vim-jsdoc/jobs/698386627#L265

Could you fix it?

@Cyperwu
Copy link
Contributor Author

Cyperwu commented Jun 17, 2020

@heavenshell yep, still trying.

@vimark1
Copy link
Contributor

vimark1 commented Jun 26, 2020

@heavenshell @Cyperwu I created #92 to fix CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants