Skip to content

fix(sdk): add instance option for instantiable SDKs #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jun 5, 2025

Closes #926

Related to #940
Related to #1932
Related to #671

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: dc7535e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 10:50am

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 10.12658% with 497 lines in your changes missing coverage. Please review.

Project coverage is 21.85%. Comparing base (4371393) to head (dc7535e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/openapi-ts/src/plugins/@hey-api/sdk/operation.ts 4.02% 310 Missing ⚠️
...ckages/openapi-ts/src/plugins/@hey-api/sdk/auth.ts 2.59% 75 Missing ⚠️
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 9.21% 69 Missing ⚠️
packages/openapi-ts/src/compiler/utils.ts 12.50% 14 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 25.00% 9 Missing ⚠️
...ages/openapi-ts/src/plugins/@hey-api/sdk/config.ts 14.28% 6 Missing ⚠️
packages/openapi-ts/src/compiler/types.ts 0.00% 4 Missing ⚠️
packages/openapi-ts/src/utils/transform.ts 40.00% 3 Missing ⚠️
packages/openapi-ts/src/compiler/classes.ts 85.71% 2 Missing ⚠️
...enapi-ts/src/plugins/@hey-api/sdk/plugin-legacy.ts 81.81% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   21.90%   21.85%   -0.06%     
==========================================
  Files         269      271       +2     
  Lines       24829    24957     +128     
  Branches      864      865       +1     
==========================================
+ Hits         5439     5454      +15     
- Misses      19384    19497     +113     
  Partials        6        6              
Flag Coverage Δ
unittests 21.85% <10.12%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

pkg-pr-new bot commented Jun 5, 2025

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@2130

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@2130

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@2130

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@2130

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2130

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2130

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2130

commit: dc7535e

@mrlubos mrlubos force-pushed the feat/sdk-instance branch from 174c967 to dc7535e Compare June 5, 2025 10:49
@mrlubos mrlubos marked this pull request as ready for review June 5, 2025 10:50
@mrlubos mrlubos changed the title fix(sdk): add instance option for instantiable SDKs fix(sdk): add instance option for instantiable SDKs Jun 5, 2025
@mrlubos mrlubos merged commit 2b3700c into main Jun 5, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the feat/sdk-instance branch June 5, 2025 10:54
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full SDK generator
1 participant