Skip to content

Conversation

sebersole
Copy link
Member

Upgrade to Gradle 9.1

I'll add commit (or new PR) updating to Java 25 for the actions and jenkins jobs after veryifing these changes work across all the jobs first.

Markdown Javadoc... here we come!


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 7, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [f6164b3, 5d80fbc, d8b90d8, 6a9d73e, fb91202]

› This message was automatically generated.

import org.gradle.api.tasks.PathSensitivity;
import org.gradle.api.tasks.TaskAction;

import static org.hibernate.orm.jakarta.JakartaPlugin.JAKARTA;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice way to resolve any incompatibilities with Gradle 9 in this task 🥳 🙂 !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. Well its also completely unnecessary - I think we are done with all our javax -> jakarta transformations at this point ;)

Comment on lines +26 to +28
final Configuration dialectConfig = project.getConfigurations()
.maybeCreate( DIALECT_CONFIG_NAME )
.setDescription( "Used to define classpath for performing reflection on Dialects for the Dialect report" );

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'Configuration dialectConfig' is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants