HHH-13884 Order.reverse() contract #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seregamorph
force-pushed
the
HHH-13884-order-reverse-contract
branch
from
ad82400 to
12060d1
Compare
|
Seems a good catch. JPA does require to return a new Order instance. The implementation is based on fluent API design. One of the concern is this code change might break our client's code, but if JPA dictates it, it might be the way we should go. |
NathanQingyangXu
approved these changes
Feb 28, 2020
|
@NathanQingyangXu any objections to merge it? |
|
I have approved but I have no rights to merge it for I am not a team member. |
|
@beikov any chance to accept this? If no, let's close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-13884
backport for #3272
javax.persistence.criteria.Order.reverse() method javadoc explicitly declares that
reverse()should return new instance.