Skip to content

CCE in simple criteria query with StatelessSession due to cast to ReactiveSession #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gavinking opened this issue Apr 21, 2025 · 3 comments · Fixed by #2216 or #2210
Closed

CCE in simple criteria query with StatelessSession due to cast to ReactiveSession #2209

gavinking opened this issue Apr 21, 2025 · 3 comments · Fixed by #2216 or #2210
Assignees
@gavinking
Labels
bug Something isn't working
Milestone
3.0.0.CR1

Comments

@gavinking
Copy link
Member

gavinking commented Apr 21, 2025 •
edited by DavideD
Loading

ReactiveEntitySelectFetchInitializer casts to ReactiveSession instead of ReactiveQueryProducer.

This is pretty bad. We should audit other casts to ReactiveSession and make sure there are no other such bugs.
@gavinking gavinking added the bug Something isn't working label Apr 21, 2025
@gavinking gavinking self-assigned this Apr 21, 2025
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 21, 2025
@gavinking
[hibernate#2209] fix cast to ReactiveSession that broke StatelesSession
402ce62
gavinking added a commit that referenced this issue Apr 21, 2025
@gavinking
[#2209] fix more unnecessary casts to ReactiveSession
e125b9f 
at least some of these are not actually bugs, but some others look sus
gavinking added a commit that referenced this issue Apr 21, 2025
@gavinking
[#2209] fix test that failed only on Maria
c4702b6
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 21, 2025
@gavinking
[hibernate#2209] fix more unnecessary casts to ReactiveSession
5b4c054 
at least some of these are not actually bugs, but some others look sus
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 21, 2025
@gavinking
[hibernate#2209] fix more unnecessary casts to ReactiveSession
ced2a74 
at least some of these are not actually bugs, but some others look sus
@DavideD
Copy link
Member

DavideD commented Apr 23, 2025

What was the failure with Maria about?

@gavinking
Copy link
Member Author

The test assumed the query returned the rows in a certain order, IIRC.

DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Apr 24, 2025
@gavinking @DavideD
[hibernate#2209] fix cast to ReactiveSession that broke StatelessSession
7f87d9b
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Apr 24, 2025
@gavinking @DavideD
[hibernate#2209] fix more unnecessary casts to ReactiveSession
7e5194c 
at least some of these are not actually bugs, but some others look sus
@DavideD DavideD mentioned this issue Apr 24, 2025
Merged
This was linked to pull requests Apr 24, 2025
[2.4] CCE in simple criteria query with StatelessSession due to cast to ReactiveSession #2216
Merged
[#2209] fix cast to ReactiveSession that broke StatelesSession #2210
Merged
DavideD pushed a commit that referenced this issue Apr 24, 2025
@gavinking @DavideD
[#2209] fix cast to ReactiveSession that broke StatelessSession
72fdc5a
DavideD pushed a commit that referenced this issue Apr 24, 2025
@gavinking @DavideD
[#2209] fix more unnecessary casts to ReactiveSession
5e26d30 
at least some of these are not actually bugs, but some others look sus
@DavideD DavideD added this to the 3.0.0.CR1 milestone Apr 24, 2025
@DavideD
Copy link
Member

DavideD commented Apr 25, 2025

I'm going to close this issue and consider it done.
If something else fails we will fix it.

Thanks

@DavideD DavideD closed this as completed Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinking gavinking

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0.CR1
2 participants
@DavideD @gavinking