Skip to content

DLS-9829 Upgrade Bootstrap #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2024
Merged

DLS-9829 Upgrade Bootstrap #182

merged 4 commits into from
Jan 30, 2024

Conversation

LAJW
Copy link
Contributor

@LAJW LAJW commented Jan 30, 2024

No description provided.

@platops-pr-bot
Copy link

  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.prefix can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.backend.BackendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Please remove ExecutionContext.Implicits.global from app/uk/gov/hmrc/helptosaveapi/auth/Auth.scala - ExecutionContext should be injected otherwise MDC logging will be broken
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@platops-pr-bot
Copy link

  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.prefix can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.backend.BackendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Please remove ExecutionContext.Implicits.global from app/uk/gov/hmrc/helptosaveapi/auth/Auth.scala - ExecutionContext should be injected otherwise MDC logging will be broken
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@LAJW LAJW merged commit eb8dcdb into main Jan 30, 2024
@LAJW LAJW deleted the lajw/DLS-9829/Upgrade-Bootstrap branch January 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno1985 johno1985 johno1985 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LAJW @platops-pr-bot @johno1985