Skip to content

Fix avatar row in settings with untrusted certificates #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2022

Conversation

zacwest
Copy link
Member

@zacwest zacwest commented May 27, 2022

Summary

Use an auth challenge aware URLSession to download the avatar. Missed this one internal use of URLSession.session in #2131.

Screenshots

@zacwest zacwest enabled auto-merge (squash) May 27, 2022 23:35
@zacwest zacwest disabled auto-merge May 27, 2022 23:46
@zacwest zacwest force-pushed the account-row-insecure branch from c826535 to a931580 Compare May 27, 2022 23:51
@zacwest zacwest enabled auto-merge (squash) May 28, 2022 00:00
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #2142 (a931580) into master (662eec4) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
+ Coverage   28.46%   28.55%   +0.09%     
==========================================
  Files         269      269              
  Lines       29838    29814      -24     
==========================================
+ Hits         8492     8513      +21     
+ Misses      21346    21301      -45     
Impacted Files Coverage Δ
Sources/App/Settings/Eureka/AccountRow.swift 0.00% <0.00%> (ø)
...rces/Shared/Common/Extensions/URL+Extensions.swift 42.22% <0.00%> (-13.34%) ⬇️
...ces/Shared/API/Webhook/Sensors/StorageSensor.swift 98.59% <0.00%> (+0.02%) ⬆️
...hared/Notifications/LocalPush/LocalPushEvent.swift 99.37% <0.00%> (+0.62%) ⬆️
Sources/Shared/API/Models/RealmZone.swift 67.84% <0.00%> (+1.76%) ⬆️
...rces/Shared/API/Models/WebhookUpdateLocation.swift 93.25% <0.00%> (+2.24%) ⬆️
Sources/Shared/Environment/DeviceWrapper.swift 43.97% <0.00%> (+4.96%) ⬆️
Sources/Shared/Environment/Constants.swift 73.45% <0.00%> (+5.30%) ⬆️
Sources/Shared/Common/BackgroundTask.swift 95.08% <0.00%> (+8.19%) ⬆️
Sources/Shared/API/WatchHelpers.swift 21.68% <0.00%> (+14.45%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662eec4...a931580. Read the comment docs.

@zacwest zacwest merged commit f38a1e5 into master May 28, 2022
@zacwest zacwest deleted the account-row-insecure branch May 28, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants