The header content contains invalid characters？

[pycodev]

I install the package and write a simple html page to try it.
Then I typed "http-server", the server was on.
But when I tried to visit the url, I got this error:

[Thu, 11 Feb 2016 06:18:12 GMT] "GET /" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.103 Safari/537.36" _http_outgoing.js:348 throw new TypeError('The header content contains invalid characters'); ^

TypeError: The header content contains invalid characters
at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:348:11)
at ResponseStream.(anonymous function) [as setHeader] (D:\Programme\nodejs\node_global\node_modules\http-server\node_modules\union\lib\response-stream.js:88:34)
at serve (D:\Programme\nodejs\node_global\node_modules\http-server\node_modules\ecstatic\lib\ecstatic.js:204:11)
at D:\Programme\nodejs\node_global\node_modules\http-server\node_modules\ecstatic\lib\ecstatic.js:134:11
at FSReqWrap.oncomplete (fs.js:82:15)

I don't know why?

[XciD]

+1 on WIN10 with Chrome

[ggevgg]

+1 win 7, chrome, node 5.6.0

[bendzinks]

It works fine with older node.js version (5.4.1).

[J-F-Liu]

On my machine, the setHeader function receives the following arguments:

{ '0': 'server', '1': 'ecstatic-0.7.6' }
{ '0': 'content-type', '1': 'text/html' }
{ '0': 'etag', '1': '"844424930269763-0-Fri Sep 11 2015 23:22:46 GMT+0800 (中国标准时间)"' }

Seems 中国标准时间 are reported as invalid characters.

[wolfsilver]

\http-server\node_modules\ecstatic\lib\ecstatic\etag.js

module.exports = function (stat) {
  return JSON.stringify([stat.ino, stat.size, stat.mtime.toJSON()].join('-'));
}

[MagicZL]

@ wolfsilver it worked.

[vitalets]

+1 win7 ie10

[doricat]

@wolfsilver Thanks.
https://github.com/jfhbrook/node-ecstatic/blob/master/lib/ecstatic/etag.js

[indexzero]

@doricat @wolfsilver @MagicZL Not sure I follow the solution, but it sounds like it is a fix to ecstatic itself. Can you make a PR there with the update?

[wolfsilver]

you're welcome.

On Fri, Feb 19, 2016 at 1:13 PM, Tim Wang notifications@github.com wrote:

@wolfsilver https://github.com/wolfsilver Thanks.
https://github.com/jfhbrook/node-ecstatic/blob/master/lib/ecstatic/etag.js

—
Reply to this email directly or view it on GitHub
#244 (comment)
.

[wolfsilver]

the leatest version has solved the problem

On Fri, Feb 19, 2016 at 1:49 PM, Charlie Robbins notifications@github.com
wrote:

@doricat https://github.com/DoriCat @wolfsilver
https://github.com/wolfsilver @MagicZL https://github.com/MagicZL Not
sure I follow the solution, but it sounds like it is a fix to ecstatic
itself. Can you make a PR there with the update?

—
Reply to this email directly or view it on GitHub
#244 (comment)
.

[indexzero]

@wolfsilver the latest version of node solved it? or the latest version of ecstatic? I'm confused because this issue was opened 8 days ago and ecstatic hasn't changed since January.

[wolfsilver]

the latest version of ecstatic check https://github.com/indexzero/http-server/blob/master/package.json#L64 maybe it still depends the older version.

[indexzero]

Ah that's it!

[indexzero]

Fixed and published in 0.9.0