Skip to content

update portfinder version to fix auto increment port #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

w3cj
Copy link

@w3cj w3cj commented Mar 23, 2016

Old version of portfinder is broken and does not find an open port.

Fixes issue: #215

@derhuerst
Copy link

@w3cj

"portfinder": "~1.0.2"

What about using a caret (^) range.

@w3cj
Copy link
Author

w3cj commented Mar 23, 2016

Currently the exact version (0.4.0) of portfinder is set in the package.json and portfinder recently went from 0.4.0 to 1.x

I'm for ~ range to at least get patches, but avoid any compatibility issues with minor versions.

@derhuerst
Copy link

I'm for ~ range to at least get patches, but avoid any compatibility issues with minor versions.

I'd assume that portfinder adheres to semver and therefore usually doesn't have compatibility problems with minor bumps. The value of semver stands or falls by it's adoption.

@cmckni3
Copy link

cmckni3 commented Sep 2, 2016

I agree with @derhuerst on this. Use and adopt semver but do some sort of QA.

Personally, I prefer 1.x over ^1.0.2 but these are equivalent.

@BigBlueHat
Copy link
Member

989fa1c sets the portfinder dependency to ^1.0.13--which I hope does the trick for everyone! If now, PRs welcome. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants