-
Notifications
You must be signed in to change notification settings - Fork 2k
Alternatives to http-proxy #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @paulrutter for this snippet, I was looking into migrating some old code too, and I came up with this using fetch API async function handler(req: Request): Promise<Response> {
const parsedUrl = new URL(req.url);
// transform request
parsedUrl.host = API_HOST;
// add forwarded headers
req.headers.append("x-forwarded-for", req.headers.get("host") ?? DEFAULT_HOST);
// fetch should handle pipeing ReadStream/WriteStream
return fetch(new Request(parsedUrl, req));
} It's pretty simple, but I believe its extendable too to add extra pre/post processing if needed. Currently I'm using this only for dev. |
@med8bra thanks, that seems pretty easy as well. It doesn't pipe the proxied response (headers, statusCode, body) though, but that could be added probably. |
Another thing to handle in my code snippet would be request timeout and set-cookie headers, which would need to be rewritten (if cookies are relevant to the proxy). Http-proxy does both as well. |
How about Hono Proxy Helper? I have not tried yet but Hono is nice framework. |
For us the hono proxy wasn't an option as it does not support websocket |
It seems like https://www.npmjs.com/package/http-proxy-node16 (i.e., https://github.com/Jimbly/http-proxy-node16) is the closest to a 'maintained' fork right now. Some big projects like JupyterHub have switched to it: https://github.com/jupyterhub/configurable-http-proxy/blob/4.6.2/CHANGELOG.md |
I started work on a modern typescript rewrite of http-proxy: STATUS compared to http-proxy:
I'm working on this because (1) there are many security issues revealed by "npm audit" which is bad for compliance, (2) the websocket implementation has leaks which are causing problems for my work, and (3) http-proxy is clearly not being maintained anymore, so somebody has to step up. I hope I can finish the test/examples soon, so that this could be considered usable. Also, unlike with http-proxy, I will be responsive regarding PR's. If anybody is interested in helping out, please do. -- William |
I turned many of the examples into unit tests, and I'm now much more confident in http-proxy-3. Again, as mentioned in the README, etc., if anybody wants to contribute in any way, I'm very open to that. E.g., there are a lot of unit tests that could still be updated... |
I spent all week and modernized ALL the unit tests from the original http-proxy, and also made all of their examples into unit tests that are tested to work (they were not actually tested in http-proxy). I fixed various vulnerabilities and issues (some revealed by unit testing). I also added some tests involving websockets along with instrumenting counting how many sockets are open to ensure leaks like reported here don't recur. It's running live now on http://cocalc.com. So now I think this is ready for general use and contributions: https://www.npmjs.com/package/http-proxy-3 There are a LOT of tests -- like 5x more lines of test code than the core library. This was a lot of work :-) |
I've been using this module for a long time for http proxying, but since it's no longer maintained i was looking into alternatives.
For what it's worth, sharing my findings here.
Using node basic modules
My usecase: i have a
expressjs
app for which i want to proxy all requests to a Node process running on the same machine, on a different port. This code snippet shows how to proxy request/response including error handling.This snippet doesn't offer everything this module offers, but it's easily extendable to add features like adding/removing headers from the request or response. It's all plain node code, no additional module involved.
Other proxy modules or ways to do it
I hope this is helpful to others moving away from
http-proxy
.The text was updated successfully, but these errors were encountered: