changes #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Vaibhavs10 merged 1 commit into main from llama4_modif

Apr 8, 2025

Contributor

eliebak commented Apr 7, 2025

Smol changes for Llama4 blog post:

Changes the link of HF to transformer version
Add detail about MetaP and Co distillation
Little changes on the arch part @pcuenca
remove the mention suggesting QK Norm help long context (see https://x.com/_arohan_/status/1908737240425177145)
it's RMS norm (despite the naming) and added the fact that there is no learnable param


          changes

e2aade5

Vaibhavs10 approved these changes

View reviewed changes

sergiopaniego approved these changes

View reviewed changes

Vaibhavs10 merged commit 71b03e6 into main

Vaibhavs10 deleted the llama4_modif branch

April 8, 2025 16:32

sergiopaniego pushed a commit to sergiopaniego/blog that referenced this pull request


          changes (huggingface#2793)

2c63910

Member

pcuenca commented Apr 8, 2025

Thank you @eliebak 🙌

You are right, it's RMS, I got misled by the class name in the original codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet