-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[LoRA] Improve warning messages when LoRA loading becomes a no-op #10187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
cd88a4b
updates
sayakpaul b694ca4
updates
sayakpaul 1db7503
updates
sayakpaul 6134491
updates
sayakpaul db827b5
Merge branch 'main' into improve-lora-warning-msg
sayakpaul ac29785
notebooks revert
sayakpaul 3f4a3fc
resolve conflicts
sayakpaul b6db978
Merge branch 'main' into improve-lora-warning-msg
sayakpaul c44f7a3
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 876132a
fix-copies.
sayakpaul bb7c09a
Merge branch 'main' into improve-lora-warning-msg
sayakpaul e6043a0
seeing
sayakpaul 7ca7493
fix
sayakpaul ec44f9a
revert
sayakpaul 343b2d2
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 615e372
fixes
sayakpaul e2e3ea0
fixes
sayakpaul f9dd64c
fixes
sayakpaul a01cb45
remove print
sayakpaul da96621
fix
sayakpaul a91138d
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 83ad82b
Merge branch 'main' into improve-lora-warning-msg
sayakpaul be187da
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 726e492
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 3efdc58
fix conflicts
sayakpaul cf50148
conflicts ii.
sayakpaul b2afc10
updates
sayakpaul 96eced3
fixes
sayakpaul b4be719
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 8bf1173
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 0e43b55
Merge branch 'main' into improve-lora-warning-msg
hlky 1e4dbbc
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 9eb460f
better filtering of prefix.
sayakpaul 279ee91
Merge branch 'main' into improve-lora-warning-msg
sayakpaul 6240876
Merge branch 'main' into improve-lora-warning-msg
sayakpaul cf9027a
Merge branch 'main' into improve-lora-warning-msg
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixes
- Loading branch information
commit e2e3ea09f98ce1ace7940511b6c23c406e82d356
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case
prefix
is not None and noprefix
matched state dict keys are found, we log from theload_lora_adapter()
method.This way, we cover for both
load_lora_weights()
which is pipeline-level andload_lora_adapter()
which is model-level.