Skip to content

Add Serialized Type Name kwarg in Model Output #10502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025

Conversation

anzr299
Copy link
Contributor

@anzr299 anzr299 commented Jan 8, 2025

What does this PR do?

Serialized Type Name kwarg which can be used to export and save the model in pytorch

Fixes # (issue)
This Pytorch Issue

@yiyixuxu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Feb 28, 2025
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Apr 21, 2025
@yiyixuxu yiyixuxu requested a review from Copilot April 21, 2025 18:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a serialized type name keyword argument to the model output registration, which allows models saved in PyTorch to include their type information.

  • Automatically sets the serialized type name using the class's module and name.
  • Updates the subclass registration in outputs.py.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit aff574f into huggingface:main Apr 21, 2025
12 checks passed
@yiyixuxu
Copy link
Collaborator

thanks a lot @anzr299 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants