enable 2 test cases on XPU #11332
Merged
enable 2 test cases on XPU #11332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YAO Matrix <[email protected]>
|
@bot /style |
|
Style fixes have been applied. View the workflow run here. |
DN6
approved these changes
Apr 16, 2025
|
@hlky , pls help review, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test cases
questions
tests/quantization/bnb/test_mixed_int8.py, I changed the hard-coding"cuda"todevice. I tried directly it's OK to directly usetorch_device, but I guess the reason you didn't use it is that maybe "rocm" system cannot work under "rocm"to(), but work on "cuda"to, so I added+ device = torch_device if torch_device != "rocm" else "cuda"to workaround. This is just a guess, @hlky, let me know if you think it's not correct.@hlky , pls help review, thx.