-
Notifications
You must be signed in to change notification settings - Fork 6k
[test_models_transformer_hunyuan_video] help us test torch.compile() for impactful models #11431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_models_transformer_hunyuan_video] help us test torch.compile() for impactful models #11431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I just ran the tests but ran into errors: https://pastebin.com/A6c4gnwd.
@a-r-r-o-w possible to take a look when you have a moment?
def test_gradient_checkpointing_is_applied(self): | ||
expected_set = {"HunyuanVideoTransformer3DModel"} | ||
super().test_gradient_checkpointing_is_applied(expected_set=expected_set) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done in a separate PR.
Yeah, our Hunyuan implementation is not compatible with |
Reopening as this PR has the test case. |
I have run the tests and they also pass: export RUN_SLOW=1
export RUN_COMPILE=1
pytest tests/models/transformers/test_models_transformer_hunyuan_video.py -k "test_torch_compile_recompilation_and_graph_break" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
Part of #11430
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.