Skip to content

Apply Occam's Razor in position embedding calculation #11562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

Apply Occam's Razor in position embedding calculation #11562

merged 5 commits into from
Jun 11, 2025

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented May 15, 2025 •
edited
Loading

Eliminate unnecessary indexing in the calculation of frequency values for the position embedding, simplifying the code.
Context: #11518 (comment)

@a-r-r-o-w @yiyixuxu

@tolgacangoz tolgacangoz changed the title Remove redundant indexing in position embedding calculation Apply Occam's Razor in position embedding calculation May 15, 2025
a-r-r-o-w
a-r-r-o-w approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu May 15, 2025 16:26
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tolgacangoz tolgacangoz requested a review from a-r-r-o-w June 11, 2025 12:23
yiyixuxu
yiyixuxu approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! sorry for the delay

@yiyixuxu yiyixuxu merged commit 47ef794 into huggingface:main Jun 11, 2025
12 checks passed
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the remove-redundant-indexing branch June 12, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@a-r-r-o-w a-r-r-o-w Awaiting requested review from a-r-r-o-w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolgacangoz @HuggingFaceDocBuilderDev @yiyixuxu @a-r-r-o-w