Skip to content

fix inpainting pipeline when providing initial latents #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2023
Merged

fix inpainting pipeline when providing initial latents #3641

merged 2 commits into from
Jun 2, 2023

Conversation

@yiyixuxu
Copy link
Collaborator

@yiyixuxu yiyixuxu commented Jun 1, 2023

@yiyixuxu yiyixuxu mentioned this pull request Jun 1, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sayakpaul
sayakpaul reviewed Jun 2, 2023
View reviewed changes
src/diffusers/pipelines/controlnet/pipeline_controlnet_inpaint.py
Comment on lines +871 to +872
noise = latents.to(device)
latents = noise * self.scheduler.init_noise_sigma
Copy link
Member

@sayakpaul sayakpaul Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the latents are being assigned as noise and then they're being assigned as latents. I find this exchange somewhat confusing. Could we change that?

Copy link
Contributor

@patrickvonplaten patrickvonplaten Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok for me since that's the first time latents is seen

sayakpaul
sayakpaul approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@patrickvonplaten patrickvonplaten merged commit 0e86881 into main Jun 2, 2023
@patrickvonplaten patrickvonplaten deleted the fix-inpaint branch June 2, 2023 16:03
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@yiyixuxu
fix inpainting pipeline when providing initial latents (huggingface#3641
2f6bd67 
)

* fix latents

* fix copies

---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@yiyixuxu
fix inpainting pipeline when providing initial latents (huggingface#3641
e725067 
)

* fix latents

* fix copies

---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inpainting pipeline throws exception when providing latents

5 participants

@yiyixuxu @HuggingFaceDocBuilderDev @sayakpaul @patrickvonplaten