Skip to content

Text2video zero refinements #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 12, 2023

Conversation

19and99
Copy link
Contributor

@19and99 19and99 commented Jun 9, 2023

  • Add new CrossFrameAttnProcessor2_0 using Pytorch 2.0 scaled_dot_product_attention
  • TextToVideoZeroPipeline chooses CrossFrameAttnProcessor2_0 as attention processor when Pytorch 2.0 is available
  • Add frame_ids parameter to TextToVideoZeroPipeline call function to allow generating longer videos chunk-by-chunk
  • Add chunk-by-chunk generation documentation in Text2Video-Zero docs

Closes: #3434

@sayakpaul sayakpaul self-requested a review June 9, 2023 13:52
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Have you ensured that the existing tests pass with PT 2.0?

@19and99
Copy link
Contributor Author

19and99 commented Jun 12, 2023

LGTM! Thank you.

Have you ensured that the existing tests pass with PT 2.0?
TextToVideoZeroPipeline pipeline tests are passing locally on PT 2.0.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul
Copy link
Member

@19and99 we need to ensure the tests are passing here.

Also you probably to add comments in #3733 (comment).

@patrickvonplaten
Copy link
Contributor

Test failures are unrelated merging!

@patrickvonplaten patrickvonplaten merged commit a812fb6 into huggingface:main Jun 12, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* fix docs typos. add frame_ids argument to text2video-zero pipeline call

* make style && make quality

* add support of pytorch 2.0 scaled_dot_product_attention for CrossFrameAttnProcessor

* add chunk-by-chunk processing to text2video-zero docs

* make style && make quality

* Update docs/source/en/api/pipelines/text_to_video_zero.mdx

Co-authored-by: Sayak Paul <[email protected]>

---------

Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix docs typos. add frame_ids argument to text2video-zero pipeline call

* make style && make quality

* add support of pytorch 2.0 scaled_dot_product_attention for CrossFrameAttnProcessor

* add chunk-by-chunk processing to text2video-zero docs

* make style && make quality

* Update docs/source/en/api/pipelines/text_to_video_zero.mdx

Co-authored-by: Sayak Paul <[email protected]>

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Text-to-video Zero] improvements in the attention processor with PT 2.0
4 participants