Skip to content

feat: add PR template. #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2023
Merged

feat: add PR template. #3786

merged 3 commits into from
Jun 15, 2023

Conversation

sayakpaul
Copy link
Member

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 14, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can we also link to the Philosophy doc here: https://github.com/huggingface/diffusers/blob/main/PHILOSOPHY.md

Think that's important for more complex PRs

@sayakpaul
Copy link
Member Author

@patrickvonplaten addressed your feedback.

@sayakpaul sayakpaul merged commit 77f9137 into main Jun 15, 2023
@sayakpaul sayakpaul deleted the feat/pr-template branch June 15, 2023 14:11
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* feat: add PR template.

* address pr comments.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Patrick von Platen <[email protected]>

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants