-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fix some audio tests #3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some audio tests #3841
Conversation
expected_slice = np.array([120, 139, 147, 123, 124, 96, 115, 121, 126, 144]) | ||
|
||
assert np.abs(image_slice.flatten() - expected_slice).max() == 0 | ||
# TODO(teticio) - not sure how exactly this should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teticio, the test test_audio_diffusion
is currently failing on "main" and I don't fully understand what's going on there. I'm disabling the tests for now. It would be amazing if you could take a look at what's going on here though :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good:)
# image_slice = np.frombuffer(image.tobytes(), dtype="uint8")[:10] | ||
# expected_slice = np.array([120, 139, 147, 123, 124, 96, 115, 121, 126, 144]) | ||
|
||
# assert np.abs(image_slice.flatten() - expected_slice).max() == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickvonplaten can't we just skip it with a decorator instead of commenting it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it's resolved soon :-) cc #3841 (comment)
@patrickvonplaten from here, let's make sure to only test for xformers when we have a GPU available. |
* Fix some audio tests * make style * fix * make style
This PR fixes the following failing slow tests: