-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[Enhance] Add LoRA rank args in train_text_to_image_lora #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Add LoRA rank args in train_text_to_image_lora #3866
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me! @sayakpaul wdyt?
Thanks for the PR! Could you help me understand why the addition of |
@sayakpaul Yes. For example,
https://github.com/KohakuBlueleaf/LyCORIS
https://github.com/darkstorm2150/sd-scripts/blob/main/docs/train_network_README-en.md |
Thanks for providing the explanation! I guess we can safely ignore that when training using |
@sayakpaul Sounds good. I fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias 🙏
…#3866) * add rank args in lora finetune * del network_alpha
What does this PR do?
・Add LoRA rank and network_alpha args in train_text_to_image_lora.py
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.