-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Improve SD XL #3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SD XL #3968
Conversation
steps_offset=1, | ||
timestep_spacing="leading", | ||
) | ||
scheduler = EulerDiscreteScheduler.from_config(scheduler_dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we pass a scheduler in? i would like to be able to convert it and attach DDIM, as that's a better sampler for SDXL even though it's divergent from their upstream impl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of being able to customize the scheduler. I like Euler, but I usually customize the settings of the scheduler.
original_size: Tuple[int, int] = (1024, 1024), | ||
original_size: Tuple[int, int] = None, | ||
crops_coords_top_left: Tuple[int, int] = (0, 0), | ||
target_size: Tuple[int, int] = (1024, 1024), | ||
target_size: Tuple[int, int] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this now defaulting to None? can you explain a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will then later be set to the passed height
and width
this makes sure we generate correct outputs for different input sizes than 1024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing the CKPT converter.
i want to increase the batch_size to get larger throughput,but i got linear growth of latency.if i run some incorrect settings? |
* improve sd xl * correct more * finish * make style * fix more
* improve sd xl * correct more * finish * make style * fix more
What does this PR do?
This PR makes sure
diffusers
Stable Diffusion XL can generate images of any size. We also make sure that both single file format and diffusers format can be loaded.Diffusers format:
Single File Format:
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.