FIX force_download
in download utility
#4036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2515, the implementation to load models has being refactored to make loading faster. However, the
force_download
parameter is not respected anymore. This PR fixes it.Though
force_download
is a very niche use case, it is still useful when one wants to be sure to restart from scratch, no matter if there cache system got corrupted. It also ease things when debugging (for context: huggingface/huggingface_hub#1549)