Skip to content

FIX force_download in download utility #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Wauplin
Copy link
Collaborator

@Wauplin Wauplin commented Jul 11, 2023

In #2515, the implementation to load models has being refactored to make loading faster. However, the force_download parameter is not respected anymore. This PR fixes it.

Though force_download is a very niche use case, it is still useful when one wants to be sure to restart from scratch, no matter if there cache system got corrupted. It also ease things when debugging (for context: huggingface/huggingface_hub#1549)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 11, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patrickvonplaten patrickvonplaten merged commit 6632823 into main Jul 11, 2023
@patrickvonplaten patrickvonplaten deleted the respect-force-download-parameter branch July 11, 2023 10:20
patrickvonplaten pushed a commit that referenced this pull request Jul 11, 2023
FIX force_download in download utils
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
FIX force_download in download utils
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
FIX force_download in download utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants