fix sdxl_lwp empty neg_prompt error issue #4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Aug 24, 2023
Comment on lines
1107
to
1109
| # negative_pooled_prompt_embeds=negative_pooled_prompt_embeds, | ||
| # lora_scale=text_encoder_lora_scale, | ||
| # ) |
There was a problem hiding this comment.
Could we maybe delete the commented code?
There was a problem hiding this comment.
Commented code is removed, and use black to fix the code quality problem.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@sayakpaul any ideas about what causes the CPU test fail? changes I made is simple one line: ...
negative_prompt = negative_prompt if negative_prompt is not None else ""
... |
|
@sayakpaul Thank You! |
6 tasks
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* fix sdxl_lwp empty neg_prompt error issue * fix sdxl_lwp empty neg_prompt error issue, update code format --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix lpw_stable_diffusion_xl empty negative prompt error issue
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul I submitted a PR to fix the empty negative prompt throw error issue for
lpw_stable_diffusion_xl.py. please help review, Thanks.reflect the discussion from: #4661 (comment)