Skip to content

[Examples] Add madebyollin VAE to SDXL LoRA example, along with an explanation #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mnslarcher
Copy link
Contributor

What does this PR do?

This PR adds the madebyollin VAE, along with an explanation of why it's a good idea to replace the original VAE with it in the SDXL LoRA example, as discussed in #4736.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear. Thanks for improving the docs!

@sayakpaul
Copy link
Member

Since it's the README of an example, it should not affect the CI. Merging 🚀

@sayakpaul sayakpaul merged commit c25c461 into huggingface:main Aug 25, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…planation (huggingface#4762)

Add madebyollin VAE to LoRA example, along with an explenation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants