[Tests and Docs] Add a test on serializing pipelines with components containing fused LoRA modules #4962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@sayakpaul If you don't mind just adding the total time taken to run these LoRA tests here as a comment? Just to have an idea of the additional overhead being introduced to the runners? The pytest summary report is fine. |
Member
Author
@DN6 find it below. |
Co-authored-by: Steven Liu <[email protected]>
|
The documentation is not available anymore as the PR was closed or merged. |
Member
Author
|
I thought #4971 fixed the FLAX problem. @patrickvonplaten? |
Co-authored-by: Patrick von Platen <[email protected]>
Contributor
|
Only failing test seems to be the flaky one. Let's merge this |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…containing fused LoRA modules (huggingface#4962) * add: test to ensure pipelines can be saved with fused lora modules. * add docs about serialization with fused lora. * Apply suggestions from code review Co-authored-by: Steven Liu <[email protected]> * Empty-Commit * Update docs/source/en/training/lora.md Co-authored-by: Patrick von Platen <[email protected]> --------- Co-authored-by: Steven Liu <[email protected]> Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
This has been quite a requested feature from the community I think.
@DN6 okay for you if we added this test?