Skip to content

Fix model offload bug when key isn't present #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Sep 14, 2023

What does this PR do?

This PR fixes an issue with enable_model_cpu_offload when a key isn't present in a checkpoint on the hub

Fixes # (issue)
#5026

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Sep 14, 2023

LGTM, the use case here is the refiner mostly: https://huggingface.co/stabilityai/stable-diffusion-xl-refiner-1.0 which doesn't have a text_encoder. We really need tests for this whole pipeline class - opening an issue about it.

@patrickvonplaten
Copy link
Contributor

Related: #5031

@DN6
Copy link
Collaborator Author

DN6 commented Sep 14, 2023

There's a flaky test. Will merge when CI is green.

@tin2tin
Copy link

tin2tin commented Sep 14, 2023

There's a flaky test. Will merge when CI is green.

Thank you. I'm standing by to release the Pallaidium Blender add-on with Würstchen implented, when this fix is comitted.

@patrickvonplaten patrickvonplaten merged commit e2033d2 into main Sep 14, 2023
@tin2tin
Copy link

tin2tin commented Sep 14, 2023

Thank you for the swift handling of this.

patrickvonplaten pushed a commit that referenced this pull request Sep 14, 2023
* fix model offload bug when key isn't present

* make style
@patrickvonplaten patrickvonplaten deleted the model-offload-fix branch September 14, 2023 16:24
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* fix model offload bug when key isn't present

* make style
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix model offload bug when key isn't present

* make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants