remove unused adapter weights in constructor #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
requested review from
DN6,
yiyixuxu,
sayakpaul and
patrickvonplaten
src/diffusers/pipelines/t2i_adapter/pipeline_stable_diffusion_adapter.py
Show resolved
Hide resolved
src/diffusers/pipelines/t2i_adapter/pipeline_stable_diffusion_adapter.py
Show resolved
Hide resolved
williamberman
force-pushed
the
will/multi_adapter_weights_constructor_remove
branch
from
fe6b614 to
34f539d
Compare
patrickvonplaten
approved these changes
Sep 18, 2023
patrickvonplaten
pushed a commit
that referenced
this pull request
Sep 18, 2023
remove adapter weights in MultiAdapter constructor
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
remove adapter weights in MultiAdapter constructor
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
remove adapter weights in MultiAdapter constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adapter class doesn't take these in the constructor. If anyone was passing them in it would have been erroring. I think this snuck its way through PR review because I remember it was part of an earlier version of the initial PR