Skip to content

[Fix enable_model_offload] Fix memory issues in tests #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2023
Merged

[Fix enable_model_offload] Fix memory issues in tests #5183

merged 4 commits into from
Sep 27, 2023

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Sep 26, 2023 •
edited
Loading

What does this PR do?

A lot of the memory issues in tests can be solved by

  1. Enabling model cpu offload
  2. Using a different (smaller) model

This PR makes the necessary changes for these tests to pass. Additionally, it fixes a small bug in enable_model_cpu_offload when self._offload_gpu_id is not properly set.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

patrickvonplaten
patrickvonplaten reviewed Sep 26, 2023
View reviewed changes
@DN6
Copy link
Collaborator Author

DN6 commented Sep 27, 2023

@patrickvonplaten Ready for another review

@patrickvonplaten patrickvonplaten merged commit ba59e92 into main Sep 27, 2023
@patrickvonplaten patrickvonplaten deleted the tests-memory-fixes branch September 27, 2023 12:05
@patrickvonplaten patrickvonplaten changed the title Fix memory issues in tests [Fix enable_model_offload] Fix memory issues in tests Sep 27, 2023
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Oct 9, 2023
@clarencechen
Remove model offload safety after huggingface#5183 has been merged
774c21b
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Oct 26, 2023
@clarencechen
Remove model offload safety after huggingface#5183 has been merged
8b4bb6e
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Oct 26, 2023
@clarencechen
Remove model offload safety after huggingface#5183 has been merged
8c1f9c1
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Oct 30, 2023
@clarencechen
Incorporate fixes from huggingface#5040
e688074 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 1, 2023
@clarencechen
Incorporate fixes from huggingface#5040
0403500 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 8, 2023
@clarencechen
Incorporate fixes from huggingface#5040
0833ec5 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 9, 2023
@clarencechen
Incorporate fixes from huggingface#5040
5ac214d 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 9, 2023
@clarencechen
Incorporate fixes from huggingface#5040
480445d 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 9, 2023
@clarencechen
Incorporate fixes from huggingface#5040
7df7151 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 9, 2023
@clarencechen
Incorporate fixes from huggingface#5040
0dd6e38 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 10, 2023
@clarencechen
Incorporate fixes from huggingface#5040
84328ae 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 13, 2023
@clarencechen
Incorporate fixes from huggingface#5040
1dbf295 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 16, 2023
@clarencechen
Incorporate fixes from huggingface#5040
9df10c9 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Nov 30, 2023
@clarencechen
Incorporate fixes from huggingface#5040
cb78e7d 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Dec 6, 2023
@clarencechen
Incorporate fixes from huggingface#5040
59393f2 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Dec 6, 2023
@clarencechen
Incorporate fixes from huggingface#5040
682366d 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Dec 13, 2023
@clarencechen
Incorporate fixes from huggingface#5040
95c5c07 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Dec 20, 2023
@clarencechen
Incorporate fixes from huggingface#5040
8e7e6d9 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@DN6
Fix memory issues in tests (huggingface#5183)
60b3de4 
* fix memory issues

* set _offload_gpu_id

* set gpu offload id
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Jan 15, 2024
@clarencechen
Incorporate fixes from huggingface#5040
cb4e256 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Jan 24, 2024
@clarencechen
Incorporate fixes from huggingface#5040
f77fda8 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Feb 13, 2024
@clarencechen
Incorporate fixes from huggingface#5040
5c3bfce 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Feb 13, 2024
@clarencechen
Incorporate fixes from huggingface#5040
7a6454c 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Feb 26, 2024
@clarencechen
Incorporate fixes from huggingface#5040
fed12cd 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Mar 15, 2024
@clarencechen
Incorporate fixes from huggingface#5040
4e40b47 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Mar 15, 2024
@clarencechen
Incorporate fixes from huggingface#5040
337a5cf 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
clarencechen added a commit to clarencechen/diffusers that referenced this pull request Apr 22, 2024
@clarencechen
Incorporate fixes from huggingface#5040
82f6ffb 
Add fast test to make sure SAG runs with Euler Scheduler

Make style

Fix CPU offload bug introduced by huggingface#5132

Update deprecated output_type attributes for tests

Remove model offload safety after huggingface#5183 has been merged
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@DN6
Fix memory issues in tests (huggingface#5183)
10941c8 
* fix memory issues

* set _offload_gpu_id

* set gpu offload id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DN6 @patrickvonplaten