-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Molecule generation model (GeoDiff) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f405837
create filestructure for science application
natolambert e4a2ddf
rebase molecule gen
natolambert 71753ef
make style
natolambert 9064eda
add property to self in init for colab
natolambert 7c15d6b
small fix to types in forward()
natolambert 120af84
rebase main, small updates
natolambert 9dd023a
add helper function to trim colab
natolambert 2d1f748
remove unused code
natolambert a4513e2
clean API for colab
natolambert ce71e2f
remove unused code
natolambert 3865892
weird rebase
natolambert 127f72a
tests pass
natolambert 2f0ac21
make style and fix-copies
natolambert 25ec89d
rename model and file
natolambert 79f25d6
update API, update tests, rename class
natolambert 7a85d04
clean model & tests
natolambert a90d1be
add checking for imports
natolambert 4d23976
minor formatting nit
natolambert 506eb3c
add attribution of original codebase
natolambert 4d158a3
style and readibility improvements
natolambert 7e73190
fixes post large rebase
natolambert 682eb47
fix tests
natolambert 77569dc
Merge remote-tracking branch 'origin/main' into molecule_gen
natolambert 2ef3727
make quality and style
natolambert 47af5ce
only import moleculegnn when ready
natolambert f5f2576
fix torch_geometric check
natolambert 104ec26
remove dummy tranformers objects
natolambert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rebase molecule gen
- Loading branch information
commit e4a2ddf7a44ea649d001de132e58c679e923b331
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the first graph network NN in this library, we should be extra careful with the naming.
Is this a universally understandable name? Do you think other graph networks would also use this architecuter? Should we make the name more generic in this case? Can we link to a paper here that defined that model architecture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to original code is above now too, I followed up with those authors asking if their's was original. https://github.com/DeepGraphLearning/ConfGF