Skip to content

[PixArt-Alpha] fix mask feature condition. #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

sayakpaul
Copy link
Member

What does this PR do?

#5677 actually broke the default behavior and was leading to crappy results. This PR fixes that.

Sincere apologies for rushing here.

Cc: @lawrence-cj

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 8, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@lawrence-cj lawrence-cj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, fixed the mask feature bug

@sayakpaul sayakpaul merged commit 78be400 into main Nov 8, 2023
@sayakpaul
Copy link
Member Author

Failing test is unrelated.

@sayakpaul sayakpaul deleted the fix/pixart-embeds-2 branch November 8, 2023 12:12
sayakpaul added a commit that referenced this pull request Nov 8, 2023
* fix mask feature condition.

* debug

* remove identical test

* set correct

* Empty-Commit
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
* fix mask feature condition.

* debug

* remove identical test

* set correct

* Empty-Commit
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* fix mask feature condition.

* debug

* remove identical test

* set correct

* Empty-Commit
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix mask feature condition.

* debug

* remove identical test

* set correct

* Empty-Commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants