-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[PixArt-Alpha] fix mask feature condition. #5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
lawrence-cj
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked, fixed the mask feature bug
sayakpaul
commented
Nov 8, 2023
patrickvonplaten
approved these changes
Nov 8, 2023
Failing test is unrelated. |
sayakpaul
added a commit
that referenced
this pull request
Nov 8, 2023
* fix mask feature condition. * debug * remove identical test * set correct * Empty-Commit
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* fix mask feature condition. * debug * remove identical test * set correct * Empty-Commit
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* fix mask feature condition. * debug * remove identical test * set correct * Empty-Commit
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* fix mask feature condition. * debug * remove identical test * set correct * Empty-Commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#5677 actually broke the default behavior and was leading to crappy results. This PR fixes that.
Sincere apologies for rushing here.
Cc: @lawrence-cj