Skip to content

Add variant argument to dreambooth lora sdxl advanced #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

levi
Copy link
Contributor

@levi levi commented Dec 1, 2023

What does this PR do?

Adds variant argument to the advanced script to support loading fp16 SDXL.

Before submitting

Who can review?

@linoytsaban @sayakpaul

@levi
Copy link
Contributor Author

levi commented Dec 1, 2023

Unable to run the make style command locally. Getting this error:

→ make style && make quality
ruff check examples scripts src tests utils setup.py --fix
ruff failed
  Cause: TOML parse error at line 16, column 1
   |
16 | [tool.ruff.format]
   | ^^^^^^^^^^^^^^^^^^
wanted exactly 1 element, more than 1 element

make: *** [style] Error 2

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sayakpaul
Copy link
Member

I suggest you do the following:

  • Create a new Python virtual environment.
  • cd into diffusers, ensuring it's rebased with the updated main.
  • Then do `pip install -e ".[quality]".
  • Then run make style && make quality.

@sayakpaul
Copy link
Member

@linoytsaban could you give this a look?

@patrickvonplaten
Copy link
Contributor

PR looks good to go for me, thanks for adding the variant=... argument. @apolinario @linoytsaban wdyt?

@linoytsaban
Copy link
Collaborator

linoytsaban commented Dec 4, 2023

Thanks @levi! LGTM!

@patrickvonplaten patrickvonplaten merged commit e185084 into huggingface:main Dec 4, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants