-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add tearDown method to LoRA tests. #6660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
gc.collect() | ||
torch.cuda.empty_cache() | ||
gc.collect() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do the LoRA tests leak memory?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@sayakpaul Not 100% certain, but it does seem like the timeout issue is more prevalent in the LoRA tests. So they might be leaking memory. |
* update * update
What does this PR do?
Some LoRA tests do not have tearDown methods. It might explain some of the timeouts we're seeing in the CI. In any case the GPU related tests should always have tearDowns.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.