Skip to content

Add tearDown method to LoRA tests. #6660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add tearDown method to LoRA tests. #6660

merged 2 commits into from
Jan 22, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Jan 22, 2024

What does this PR do?

Some LoRA tests do not have tearDown methods. It might explain some of the timeouts we're seeing in the CI. In any case the GPU related tests should always have tearDowns.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul January 22, 2024 07:32

gc.collect()
torch.cuda.empty_cache()
gc.collect()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do the LoRA tests leak memory?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator Author

DN6 commented Jan 22, 2024

@sayakpaul Not 100% certain, but it does seem like the timeout issue is more prevalent in the LoRA tests. So they might be leaking memory.

@DN6 DN6 merged commit d66d554 into main Jan 22, 2024
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants